[ 
https://issues.apache.org/jira/browse/NETBEANS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264121#comment-16264121
 ] 

lbruun commented on NETBEANS-126:
---------------------------------


There are now two alternatives:

* [PR289|https://github.com/apache/incubator-netbeans/pull/289]: Replaces the 
icons with something reasonable. Allows us to move on now with the ASF release 
despite LEGAL-343 not being resolved.
* [PR251|https://github.com/apache/incubator-netbeans/pull/251]: Reinstates the 
original browser icons. Requires LEGAL-343 to sanction this.

Suggest to do PR289 for now.

> Browser icons needs to be re-instated
> -------------------------------------
>
>                 Key: NETBEANS-126
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-126
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: lbruun
>            Assignee: lbruun
>            Priority: Minor
>              Labels: donation-fixes, pull-request-available
>         Attachments: css-editor-icons-usage.png, css-editor-icons.png, 
> nb-icon.png, web-browser-api-icons.png
>
>
> A number of browser icons were "removed" from the donation, in [this 
> changeset|http://hg.netbeans.org/releases/rev/034a0c65c347?revcount=1500]. 
> They weren't actually removed, rather they were all replaced with a dummy 
> NetBeans icon. I think Oracle removed them because Oracle couldn't donate 
> such icons, as they don't "own" these trademarks.
> h2. Module path "css.editor"
> Removed from {{css.editor}}:
> !css-editor-icons.png!
> The browser icons in this module are - as far as I can tell - only used for 
> code completion hints on CSS where they are used to signal if the browser has 
> support for the CSS property or not. Example:
> !css-editor-icons-usage.png!
> h2. Module path "web.browser.api"
> Removed from {{web.browser.api}}:
> !web-browser-api-icons.png!
> The above icons are all replaced in the donation with a dummy NetBeans icon: 
> !nb-icon.png! 
> I'll do a PR to re-instate these.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to