[
https://issues.apache.org/jira/browse/NIFI-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707080#comment-14707080
]
Bryan Bende commented on NIFI-844:
----------------------------------
Mark, Overall code looks good... a couple of things:
- There appears to a bin directory that is part of the patch and has class
files in it, and causes the contrib-check to fail.
- There are a couple of files where it looks like slight formatting got changed
on comments and indentation
- The assembly doesn't appear to include the avro-bundle.
- Minor possible performance improvement, on line 102 of the processor where it
reads the next record in a loop, I think there is a call to next() that takes a
GenericRecord to re-use so that a new object isn't created every time, probably
not a huge deal unless it was huge incoming avro file.
> Create Processor to convert Avro to JSON
> ----------------------------------------
>
> Key: NIFI-844
> URL: https://issues.apache.org/jira/browse/NIFI-844
> Project: Apache NiFi
> Issue Type: Task
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 0.3.0
>
> Attachments:
> 0001-NIFI-844-Initial-import-of-the-ConvertAvroToJSON-pro.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
