[
https://issues.apache.org/jira/browse/NIFI-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717448#comment-14717448
]
ASF GitHub Bot commented on NIFI-604:
-------------------------------------
GitHub user rickysaltzer opened a pull request:
https://github.com/apache/nifi/pull/78
NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess
- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments.
This enables
the ExecuteStreamCommand to use semicolons as part of arguments.
- Argument delimiters can now be specified. Their default being what they
were using before (ExecuteStreamCommand -> ';' , ExecuteProcess -> ' ')
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rickysaltzer/nifi NIFI-604
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 9cefc4a5a54adf63bf4eb67c4b8211f2a2b5dd14
Author: ricky <[email protected]>
Date: 2015-08-27T19:02:37Z
NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess
- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments
- Argument delimiters can now be specified. Their default being what they
were using before (; and space)
----
> ExecuteStreamCommand does not support arguments with semicolons
> ----------------------------------------------------------------
>
> Key: NIFI-604
> URL: https://issues.apache.org/jira/browse/NIFI-604
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 0.1.0
> Reporter: Ricky Saltzer
> Assignee: Mark Payne
> Fix For: 0.4.0
>
> Attachments: NIFI-604.1.patch, NIFI-604.2.patch
>
>
> The following code in ExecuteStreamCommand assumes you're not passing
> semicolons within your argument. This is a problem for people who need to
> pass semicolons to the executing program as part of the argument.
> {code}
> 224 for (String arg : commandArguments.split(";")) {
> {code}
> To allow for escaped semicolons, I propose we change this to the following
> regex.
> {code}
> 224 for (String arg : commandArguments.split("[^\\];")) {
> {code}
> *or*... could we just change the way arguments are passed to make it more
> similar to how ExecuteCommand works? The whole semicolon per argument took
> some getting used to, and doesn't seem very intuitive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
