[
https://issues.apache.org/jira/browse/NIFI-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717457#comment-14717457
]
ASF GitHub Bot commented on NIFI-604:
-------------------------------------
Github user rickysaltzer commented on the pull request:
https://github.com/apache/nifi/pull/78#issuecomment-135543956
There's one thing I would like to call attention to. Users of the
StreamCommand who were using \n \r or \t characters outside of quotes might
have unexpected results since the ExecuteProcess command used those as
delimiters in addition to the space delimiter. It's doubtful that a lot of
people were doing this, but it's something to consider.
One option is to have a "Use Default Delimiters" checkbox that's enabled by
default on the ExecuteProcess and disabled by default on the
ExecuteStreamCommand.
> ExecuteStreamCommand does not support arguments with semicolons
> ----------------------------------------------------------------
>
> Key: NIFI-604
> URL: https://issues.apache.org/jira/browse/NIFI-604
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 0.1.0
> Reporter: Ricky Saltzer
> Assignee: Mark Payne
> Fix For: 0.4.0
>
> Attachments: NIFI-604.1.patch, NIFI-604.2.patch
>
>
> The following code in ExecuteStreamCommand assumes you're not passing
> semicolons within your argument. This is a problem for people who need to
> pass semicolons to the executing program as part of the argument.
> {code}
> 224 for (String arg : commandArguments.split(";")) {
> {code}
> To allow for escaped semicolons, I propose we change this to the following
> regex.
> {code}
> 224 for (String arg : commandArguments.split("[^\\];")) {
> {code}
> *or*... could we just change the way arguments are passed to make it more
> similar to how ExecuteCommand works? The whole semicolon per argument took
> some getting used to, and doesn't seem very intuitive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
