[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986105#comment-14986105
]
Matt Gilman commented on NIFI-1086:
-----------------------------------
Contrib-check passes, the recently updated and more comprehensive unit tests
pass. I did not text exhaustively in a flow. Simply ran tests and read through
the changes. A couple things
- In configureRequest it appears the that both PUT and POST requests are
handled by the same switch case. It appears that they both end up executing the
builder.put method. I'm guessing that we need to explicitly call builder.post
when appropriate. Do we not have a unit test that covers this?
- One minor comment is the end of the onTrigger you have conditionals for
checking the response status (success or not). This should probably be
converted to and if / else block instead of two separate conditionals.
Overall, looks like a good start.
> Refactor InvokeHttp
> -------------------
>
> Key: NIFI-1086
> URL: https://issues.apache.org/jira/browse/NIFI-1086
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Fix For: 0.4.0
>
> Attachments: NIFI-1086_refactor_only.patch
>
>
> InvokeHttp currently uses Java's HttpUrlConnection, which is lacking in it's
> features and ease-of-use. In order to support all the current InvokeHttp
> pending tickets it's clear that a new underlying library is needed.
> OkHttp looks to be a promising library that focusing on individual
> transactions (as opposed to Apache's HttpClient that focuses more on
> sessions).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
