[
https://issues.apache.org/jira/browse/NIFI-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006981#comment-15006981
]
Joseph Percivall commented on NIFI-1086:
----------------------------------------
I'd be ok with making a request flowfile when there is no input regardless of
the put to attribute property. I was just thinking that since there is no
request coming in then no request flowfile would be made but I guess there
could be value in routing the potentially unique requests to retry/failure
loops. I can make the change
OkHttp's client treats 3xx in addition to 2xx as successes, currently we only
treat 2xx as success. In order to keep backwards compatibility (treating 3xx as
not success) it's easiest to just keep the current check method.
Looking at this link [1] it seems status code 0 may be unique to an error in
HttpUrlConnection. I wouldn't be opposed to throwing an exception for status
code == 0 but that is how it's currently being done in master so changing that
would mean potentially changing backwards compatibility if people are expecting
status code 0 to be an exception.
[1]
http://stackoverflow.com/questions/3753496/got-0-when-using-httpurlconnection-getresponsecode
> Refactor InvokeHttp
> -------------------
>
> Key: NIFI-1086
> URL: https://issues.apache.org/jira/browse/NIFI-1086
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Fix For: 0.4.0
>
> Attachments: NIFI-1086_02.patch, NIFI-1086_rebasing_to_master.patch
>
>
> InvokeHttp currently uses Java's HttpUrlConnection, which is lacking in it's
> features and ease-of-use. In order to support all the current InvokeHttp
> pending tickets it's clear that a new underlying library is needed.
> OkHttp looks to be a promising library that focusing on individual
> transactions (as opposed to Apache's HttpClient that focuses more on
> sessions).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
