[
https://issues.apache.org/jira/browse/NIFI-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994214#comment-14994214
]
Mark Payne commented on NIFI-817:
---------------------------------
[~bbende] - PutHBaseCell looks good to me. Only comment that I have there is
that if Put's to HBase fail, it looks like it is buffering up a
List<PutFlowFileFailure> and then at the end just logs/transfers the events. I
think we can probably get rid of that list and the PutFlowFileFailure all
together and just perform the log/transfer within the catch clause all together.
I would also recommend we change "catch (Throwable t)" to "catch (Exception
e)". We have a bad habit of catching Throwable throughout the application but
we need to clean that up and get into the habit of catching Exception, not
Throwable.
One final note, if we fail to send data, we should penalize the FlowFIle before
routing to failure.
Otherwise, all looks good! Will look into the Get Processor now.
> Create Processors to interact with HBase
> ----------------------------------------
>
> Key: NIFI-817
> URL: https://issues.apache.org/jira/browse/NIFI-817
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Bryan Bende
> Fix For: 0.4.0
>
> Attachments:
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-2.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-3.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-4.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-5.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
