[
https://issues.apache.org/jira/browse/NIFI-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994260#comment-14994260
]
Mark Payne commented on NIFI-817:
---------------------------------
[~bbende] - I also noticed that in the definition of the Controller Service,
there are two methods:
{code}
void put(String tableName, List<PutFlowFile> puts) throws IOException;
void scan(String tableName, List<Column> columns, String filterExpression, long
minTime, ResultHandler handler) throws IOException;
{code}
Any reason those methods need to take Lists instead of Collection? I think
taking a Collection in this case would be better, since the ordering of those
objects, I don't think, is really relevant.
I would also recommend that the service api be moved to the
nifi-nar-bundles/standard-services directory tree.
Otherwise, I think the code looks good!
> Create Processors to interact with HBase
> ----------------------------------------
>
> Key: NIFI-817
> URL: https://issues.apache.org/jira/browse/NIFI-817
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Bryan Bende
> Fix For: 0.4.0
>
> Attachments:
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-2.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-3.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-4.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors-5.patch,
> 0001-NIFI-817-Initial-implementation-of-HBase-processors.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
