[
https://issues.apache.org/jira/browse/NIFI-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997242#comment-14997242
]
ASF GitHub Bot commented on NIFI-1061:
--------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/117
NIFI-1061 fixed deadlock caused by DBCPConnectionPool.onConfigured()
Current implementation of DBCPConnectionPool was attempting to test if
connection could be obtained via dataSource.getConnection().
Such call is naturally a blocking call and the duration of the block is
dependent on driver implementation. Some drivers (e.g., Phoenix -
https://phoenix.apache.org/installation.html)
attempts numerous retries before failing creating a deadlock when attempt
was made to disable DBCPConnectionPool which was still being enabled.
This fix removes the connection test from DBCPConnectionPool.onConfigured()
operation returning successfully upon creation of DataSource.
For more details see comments in
https://issues.apache.org/jira/browse/NIFI-1061
The fix also cleaned up the code in
StandardProcessScheduler.getScheduleState for better readability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1061
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 370950b0193c0a64cb023b2e64d9ea40c9ad97f4
Author: Oleg Zhurakousky <[email protected]>
Date: 2015-11-09T19:47:50Z
NIFI-1061 fixed deadlock caused by DBCPConnectionPool.onConfigured()
Current implementation of DBCPConnectionPool was attempting to test if
connection could be obtained via dataSource.getConnection().
Such call is naturally a blocking call and the duration of the block is
dependent on driver implementation. Some drivers (e.g., Phoenix -
https://phoenix.apache.org/installation.html)
attempts numerous retries before failing creating a deadlock when attempt
was made to disable DBCPConnectionPool which was still being enabled.
This fix removes the connection test from DBCPConnectionPool.onConfigured()
operation returning successfully upon creation of DataSource.
For more details see comments in
https://issues.apache.org/jira/browse/NIFI-1061
The fix also cleaned up the code in
StandardProcessScheduler.getScheduleState for better readability.
----
> DBConnectionPool service unable to terminate
> --------------------------------------------
>
> Key: NIFI-1061
> URL: https://issues.apache.org/jira/browse/NIFI-1061
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Randy Gelhausen
> Assignee: Oleg Zhurakousky
> Fix For: 0.4.0
>
> Attachments: Screen Shot 2015-10-23 at 7.17.31 PM.png, nifi-app.log.gz
>
>
> I had a defined flow with an enabled DBConnectionPool using the
> phoenix-client.jar driver. After stopping the NiFi process and restarting it,
> the connection pool is unable to reconnect. Attempting to disable the pool
> never completes the operation. See attached screenshot & nifi-app.log file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
