[
https://issues.apache.org/jira/browse/NIFI-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000374#comment-15000374
]
Bryan Bende commented on NIFI-1083:
-----------------------------------
1) In the second patch, if I understand the code correctly:
{code}
final String matchLine;
if (trim) {
matchLine = line.trim();
} else {
matchLine = lineWithoutEndings;
}
{code}
In the trim case, do we want it to be lineWithoutEndings.trim() ?
2) This is very minor, but in this code:
{code}
private Group getGroup(final String line, final Pattern groupPattern) {
if (groupPattern == null) {
return EMPTY_GROUP;
} else {
final Matcher matcher = groupingRegex.matcher(line);
{code}
When it creates the Matcher should it use groupPattern? which technically is
the same thing as groupingRegex.
3) Also, I got this test failure:
Tests in error:
TestRouteText.testNotText:92 ยป NoSuchFile src/test/resources/simple.jpg
> Create Route Individual Lines of Text Processor
> -----------------------------------------------
>
> Key: NIFI-1083
> URL: https://issues.apache.org/jira/browse/NIFI-1083
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Fix For: 0.4.0
>
> Attachments:
> 0001-NIFI-1083-Added-a-Grouping-Regular-Expression-proper.patch,
> NIFI-1083_change_processor_name.patch
>
>
> Create a processor that will read individual lines of text and route them
> based on routing and matching strategies. See the parent task for a more in
> depth look
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
