[ 
https://issues.apache.org/jira/browse/NIFI-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023559#comment-15023559
 ] 

ASF GitHub Bot commented on NIFI-1192:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/131#discussion_r45687909
  
    --- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java
 ---
    @@ -70,6 +70,10 @@
                     + " the message does not have a key, or if the batch size 
is greater than 1, this attribute will not be added"),
             @WritesAttribute(attribute = "kafka.partition", description = "The 
partition of the Kafka Topic from which the message was received. This 
attribute is added only if the batch size is 1"),
             @WritesAttribute(attribute = "kafka.offset", description = "The 
offset of the message within the Kafka partition. This attribute is added only 
if the batch size is 1")})
    +@DynamicProperty(name = "The name of a Kafka configuration property.", 
value = "The value of a given Kafka configuration property.", description = 
"These properties will be added on the Kafka configuration after loading any 
provided configuration properties."
    --- End diff --
    
    @olegz this line is 260 characters; fails contrib-check. Can you break that 
line apart?


> Rework Get/PutKafka for dynamic properties and improve performance under 
> certain conditions
> -------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1192
>                 URL: https://issues.apache.org/jira/browse/NIFI-1192
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 0.3.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 0.4.0
>
>
> Currently Kafka does not honor dynamic properties which means aside from 8 
> properties exposed none others could be set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to