[ 
https://issues.apache.org/jira/browse/NIFI-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023561#comment-15023561
 ] 

ASF GitHub Bot commented on NIFI-1192:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/131#discussion_r45688059
  
    --- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestGetKafka.java
 ---
    @@ -45,13 +45,18 @@ public static void configureLogging() {
         }
     
         @Test
    -    @Ignore("Intended only for local tests to verify functionality.")
         public void testIntegrationLocally() {
    +        EmbeddedKafka kafka = new EmbeddedKafka();
    +        kafka.start();
    +
    +        kafka.addTopic("testX", 1);
    +        kafka.sendMessage("testX");
    +
             final TestRunner runner = 
TestRunners.newTestRunner(GetKafka.class);
    -        runner.setProperty(GetKafka.ZOOKEEPER_CONNECTION_STRING, 
"192.168.0.101:2181");
    +        runner.setProperty(GetKafka.ZOOKEEPER_CONNECTION_STRING, 
"localhost:2181");
             runner.setProperty(GetKafka.TOPIC, "testX");
    -        runner.setProperty(GetKafka.KAFKA_TIMEOUT, "3 secs");
    -        runner.setProperty(GetKafka.ZOOKEEPER_TIMEOUT, "3 secs");
    +        // runner.setProperty(GetKafka.KAFKA_TIMEOUT, "3 secs");
    --- End diff --
    
    If this line and the next are not needed, can you remove them rather than 
commenting them out?


> Rework Get/PutKafka for dynamic properties and improve performance under 
> certain conditions
> -------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1192
>                 URL: https://issues.apache.org/jira/browse/NIFI-1192
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 0.3.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Critical
>             Fix For: 0.4.0
>
>
> Currently Kafka does not honor dynamic properties which means aside from 8 
> properties exposed none others could be set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to