[ 
https://issues.apache.org/jira/browse/NIFI-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071967#comment-15071967
 ] 

ASF GitHub Bot commented on NIFI-1300:
--------------------------------------

Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/145#discussion_r48449724
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutJMS.java
 ---
    @@ -252,7 +252,8 @@ public void process(final InputStream in) throws 
IOException {
                     logger.info("Sent {} to JMS Server and transferred to 
'success'", new Object[]{flowFileDescription});
                 } catch (JMSException e) {
                     logger.error("Failed to commit JMS Session due to {}; 
rolling back session", new Object[]{e});
    --- End diff --
    
    This log statement is incorrect now (not being rolled back)


> PutJMS should fail flowfile on commit exception and penalize flowfiles routed 
> to failure.
> -----------------------------------------------------------------------------------------
>
>                 Key: NIFI-1300
>                 URL: https://issues.apache.org/jira/browse/NIFI-1300
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Joe Skora
>            Assignee: Joe Skora
>            Priority: Minor
>
> PutJMS fails the flowfile if an exception occurs during message send, but 
> rollsback if an exception occurs during commit.  It should fail in both cases 
> and it should penalize the flowfile for either failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to