[
https://issues.apache.org/jira/browse/NIFI-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146366#comment-15146366
]
ASF GitHub Bot commented on NIFI-1513:
--------------------------------------
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r52837465
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
@@ -426,60 +423,65 @@ public void onTrigger(final ProcessContext context,
final ProcessSessionFactory
if (accept != null) {
get.addHeader(HEADER_ACCEPT, accept);
}
+ // create the http client
+ try ( final CloseableHttpClient client = clientBuilder.build()
) {
+ // NOTE: including this inner try in order to swallow
exceptions on close
+ try {
--- End diff --
Holy smokes, this got butchered, it should just be an indentation of that
try block
> Fix high impact coverity issues
> -------------------------------
>
> Key: NIFI-1513
> URL: https://issues.apache.org/jira/browse/NIFI-1513
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: Tony Kurc
> Assignee: Tony Kurc
> Priority: Minor
>
> Coverity Scan discovered a few issues, this is a ticket to track progress on
> mitigating them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
