[
https://issues.apache.org/jira/browse/NIFI-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192094#comment-15192094
]
ASF GitHub Bot commented on NIFI-627:
-------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/274
NIFI-627 incorporates mwmoser patch and some minor formatting tweaks and
eliminates use of exception handling for flow control
NIFI-627 incorporates mwmoser patch and some minor formatting tweaks and
eliminates use of exception handling for flow control
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-627
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit 27d2c3ebb145ce10226d997828bc390381dd417b
Author: Mike Moser <mose...@apache.org>
Date: 2016-03-10T22:53:25Z
NIFI-627 removed flowfile penalization which could skew behavior when
processor's Time Duration was less than Penalty Duration, improved over
throttle penalization NIFI-990 corrected failure path NIFI-1329 refactored
using FlowFileFilter to avoid repeatedly returning flowfiles to the input
queue, producing misleading stats and excessive Tasks/Time used
Signed-off-by: joewitt <joew...@apache.org>
commit bed88cbb5f5fc10955123a15679094e3685ba00e
Author: joewitt <joew...@apache.org>
Date: 2016-03-13T02:47:16Z
NIFI-627 minor formating adjustments and removed exception based handling
logic
----
> ControlRate processor does not accurately control the rate
> ----------------------------------------------------------
>
> Key: NIFI-627
> URL: https://issues.apache.org/jira/browse/NIFI-627
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 0.1.0
> Reporter: Michael Moser
> Assignee: Michael Moser
> Priority: Minor
> Fix For: 0.6.0
>
>
> Set a ControlRate processor to something like 5 KB per 1 sec. Generate flow
> files that are about 300 KB in size and feed a bunch to this processor. This
> should allow about 5 files through per 5 minutes. But it allows a lot more
> data through than it should. The difference seems to get worse with really
> low Time Duration values. And people tend to think in number of bytes per
> second so the temptation to set Time Duration to 1 sec is great.
> Also, if ControlRate has multiple input queues, it seems to output even more
> data than it should.
> This seems to be caused by the code at the beginning of ControlRate
> onTrigger(). Under some conditions when the number of files that are allowed
> through per Time Duration is less than 1, the Throttle is being removed from
> the throttleMap while it actually still should be in use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
