[ 
https://issues.apache.org/jira/browse/NIFI-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196167#comment-15196167
 ] 

ASF GitHub Bot commented on NIFI-1118:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/280#discussion_r56234292
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
 ---
    @@ -134,6 +168,28 @@ protected void init(final 
ProcessorInitializationContext context) {
         }
     
         @Override
    +    protected Collection<ValidationResult> 
customValidate(ValidationContext validationContext) {
    +        ArrayList<ValidationResult> results = new ArrayList<>();
    +
    +        results.add(new ValidationResult.Builder()
    +            .subject("Remove Trailing Newlines")
    +            
.valid(!validationContext.getProperty(REMOVE_TRAILING_NEWLINES).asBoolean())
    +            .explanation("Property is deprecated; value must be set to 
false. Future releases may remove this Property.")
    +            .build());
    +
    +        final boolean invalidState = 
(validationContext.getProperty(LINE_SPLIT_COUNT).asInteger() == 0
    +                && 
validationContext.getProperty(FRAGMENT_MAX_SIZE).asDataSize(DataUnit.B) == 
null);
    --- End diff --
    
    I think this line should be:
    && !validationContext.getProperty(FRAGMENT_MAX_SIZE).isSet() );


> Enable SplitText processor to limit line length and filter header lines
> -----------------------------------------------------------------------
>
>                 Key: NIFI-1118
>                 URL: https://issues.apache.org/jira/browse/NIFI-1118
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Bean
>            Assignee: Joe Skora
>             Fix For: 0.6.0
>
>
> Include the following functionality to the SplitText processor:
> 1) Maximum size limit of the split file(s)
> A new split file will be created if the next line to be added to the current 
> split file exceeds a user-defined maximum file size
> 2) Header line marker
> User-defined character(s) can be used to identify the header line(s) of the 
> data file rather than a predetermined number of lines
> These changes are additions, not a replacement of any property or behavior. 
> In the case of header line marker, the existing property "Header Line Count" 
> must be zero for the new property and behavior to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to