[ 
https://issues.apache.org/jira/browse/NIFI-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202047#comment-15202047
 ] 

Mark Payne commented on NIFI-1118:
----------------------------------

Definitely in agreement with this. I added a patch to NIFI-1649 that verifies 
all of the defects that [~markbean] has laid out. Excellent job describing the 
situations that you encountered - it made writing unit tests to prove them very 
easy. Started looking at fixing the behavior, at least to ensure that we never 
stop parsing incoming data when we hit an end of line. And it certainly has 
proven to be more challenging than I expected - you guys were not kidding about 
that :) This processor could probably use a bit of refactoring and DEFINITELY 
needs some additional unit tests added. Thanks for working through all of this 
with us to get to a good state!

> Enable SplitText processor to limit line length and filter header lines
> -----------------------------------------------------------------------
>
>                 Key: NIFI-1118
>                 URL: https://issues.apache.org/jira/browse/NIFI-1118
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Bean
>            Assignee: Joe Skora
>             Fix For: 0.7.0
>
>
> Include the following functionality to the SplitText processor:
> 1) Maximum size limit of the split file(s)
> A new split file will be created if the next line to be added to the current 
> split file exceeds a user-defined maximum file size
> 2) Header line marker
> User-defined character(s) can be used to identify the header line(s) of the 
> data file rather than a predetermined number of lines
> These changes are additions, not a replacement of any property or behavior. 
> In the case of header line marker, the existing property "Header Line Count" 
> must be zero for the new property and behavior to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to