[
https://issues.apache.org/jira/browse/NIFI-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198224#comment-15198224
]
ASF GitHub Bot commented on NIFI-1636:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/285#discussion_r56419500
--- Diff:
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
@@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext
context, final ProcessSessionFa
onTrigger(context, session);
session.commit();
} catch (final Throwable t) {
- getLogger().error("{} failed to process due to {}; rolling
back session", new Object[]{this, t});
+ StringWriter stacktraceWriter = new StringWriter();
--- End diff --
I would say generally no. They are uncommon in general but when they
happen they happen in bursts. As a general rule I think we should strive to
make what the user sees be something a lot more friendly than a wild stack
trace. But, the logs should have them. We did discuss this on dev list a
while back and there were some great inputs from various folks. We def need to
do something here.
> Print entire stacktrace when unexpected exception occurs during onTrigger
> -------------------------------------------------------------------------
>
> Key: NIFI-1636
> URL: https://issues.apache.org/jira/browse/NIFI-1636
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Ricky Saltzer
> Assignee: Ricky Saltzer
>
> As of now the try/catch clause in the {{AbstractProcessor}} class doesn't
> print the entire stacktrace when a processor throws an unexpected exception.
> Printing the entire stacktrace comes especially in handy when users are
> creating custom processors for internal use.
> The difference in information can be seen below:
> *Before*
> {code}
> java.lang.NumberFormatException: For input string: "five"
> {code}
> *After*
> {code}
> java.lang.NumberFormatException: For input string: "five"
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.lang.Integer.parseInt(Integer.java:580)
> at java.lang.Integer.parseInt(Integer.java:615)
> at TestException.main(TestException.java:5)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
