[ 
https://issues.apache.org/jira/browse/NIFI-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249888#comment-15249888
 ] 

ASF GitHub Bot commented on NIFI-1788:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/368#discussion_r60407160
  
    --- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java
 ---
    @@ -94,8 +94,10 @@ public void process(InputStream in, OutputStream out) 
throws IOException {
     
                     try (final FSDataOutputStream fsDataOutputStream = new 
FSDataOutputStream(bwos, new Statistics(""));
                             final SequenceFile.Writer writer = 
SequenceFile.createWriter(configuration,
    -                                fsDataOutputStream, Text.class, 
InputStreamWritable.class, compressionType,
    -                                new DefaultCodec())) {
    +                                
SequenceFile.Writer.stream(fsDataOutputStream),
    +                                SequenceFile.Writer.keyClass(Text.class),
    +                                
SequenceFile.Writer.valueClass(InputStreamWritable.class),
    +                                
SequenceFile.Writer.compression(compressionType, new DefaultCodec()))) {
    --- End diff --
    
    @pvillard31 I would agree. In any event raising an improvement JIRA will 
let such discussion to begin.


> CreateHadoopSequenceFile shows wrong values for compression type
> ----------------------------------------------------------------
>
>                 Key: NIFI-1788
>                 URL: https://issues.apache.org/jira/browse/NIFI-1788
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Core UI
>    Affects Versions: 0.6.0
>            Reporter: Hugo Lemay-Proulx
>            Assignee: Pierre Villard
>            Priority: Minor
>
> The CreateHadoopSequenceFile processor shows that the possible values for 
> compression types are :
> NONE
> DEFAULT
> BZIP
> GZIP
> LZ4
> SNAPPY
> AUTOMATIC
> but the compression type is not the compression codec to use. It is what to 
> compress in the sequence file: 
> NONE
> RECORD
> BLOCK
> Because of that, if the selection is anything other than NONE, the processor 
> will throw an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to