[
https://issues.apache.org/jira/browse/NIFI-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249902#comment-15249902
]
ASF GitHub Bot commented on NIFI-1788:
--------------------------------------
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/368#issuecomment-212427393
@pvillard31 I know we have a lot of these "quick-fix-hit-and-run" bugs that
require half a line of code change (and you've been absolutely awesome in
knocking those out along with more complex JIRAs), but try to always remember
that we wouldn't be here if test(s) for these things existed in the first
place. So, while fixing such issue I personally strongly encourage to
add/modify/create test case as part of the fix.
Feel free to use this:
```java
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.nifi.processors.hadoop;
import static org.junit.Assert.assertEquals;
import java.util.List;
import org.apache.nifi.components.AllowableValue;
import org.apache.nifi.components.PropertyDescriptor;
import org.junit.Test;
public class CreateHadoopSequenceFileTest {
@Test
public void validateAllowableValues() {
PropertyDescriptor pd = CreateHadoopSequenceFile.COMPRESSION_TYPE;
List<AllowableValue> allowableValues = pd.getAllowableValues();
assertEquals("NONE", allowableValues.get(0).getValue());
assertEquals("RECORD", allowableValues.get(1).getValue());
assertEquals("BLOCK", allowableValues.get(2).getValue());
}
}
```
Cheers!
> CreateHadoopSequenceFile shows wrong values for compression type
> ----------------------------------------------------------------
>
> Key: NIFI-1788
> URL: https://issues.apache.org/jira/browse/NIFI-1788
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Core UI
> Affects Versions: 0.6.0
> Reporter: Hugo Lemay-Proulx
> Assignee: Pierre Villard
> Priority: Minor
>
> The CreateHadoopSequenceFile processor shows that the possible values for
> compression types are :
> NONE
> DEFAULT
> BZIP
> GZIP
> LZ4
> SNAPPY
> AUTOMATIC
> but the compression type is not the compression codec to use. It is what to
> compress in the sequence file:
> NONE
> RECORD
> BLOCK
> Because of that, if the selection is anything other than NONE, the processor
> will throw an exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
