[
https://issues.apache.org/jira/browse/NIFI-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285209#comment-15285209
]
Joe Skora commented on NIFI-1754:
---------------------------------
[~joewitt], I'm sorry about the piece meal replies, I caught your PR comments
before your summary here. This supersedes my other PR comments.
The original requirement was on an operations need, without being able to
identify flow files causing the Administrative Yield they couldn't track
whether the root causes were system issues, framework issues, processor issues,
or flow file problems. I agree that some yields are likely due to processor
programming errors, but I agree more that a yield likely "indicates a
programming error with that processor or some faulty system state." I think
there is a practical limit to what a processor can do in response to some
errors and that is where the framework can step in with changes like these to
assist the flow managers in finding the the root causes.
If I understand the gist of your comments correctly, I think the path forward
is.
1. Move the rollback count value from the FF attribute to a FlowFileRecord
property.
2. Move the unacknowledged FF logging from AbstractProcessor into the
ProcessSession where the counting already is being done.
3. Eliminate the configuration entries by moving the logging to DEBUG level to
allow it to be controlled by logging configuration if necessary and always
counting rollbacks on the FlowFileRecord.
4. Rename the FlowDebugger processor to DebugFlow and incorporate as a separate
ticket and PR.
I think this boils down to a better solution short and long term, and it
consolidates the changes. I believe it will also eliminate the 0.7.0 and 1.0.0
mismatch, so integration will be easier.
I appreciate your feedback. If you agree with this path forward, I will try to
re-work the changes and re-submit ASAP.
Thanks,
JoeS
> Rollback log messages should include the flowfile filename and UUID to assist
> in flow management.
> -------------------------------------------------------------------------------------------------
>
> Key: NIFI-1754
> URL: https://issues.apache.org/jira/browse/NIFI-1754
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.0.0, 0.7.0
> Reporter: Joe Skora
> Assignee: Joe Skora
>
> When a processor calls rollback on a flowfile, the filename and UUID of the
> flowfile should be included in log entry to make it easier for the offending
> files to be found and fixed or removed from the flow by the dataflow managers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
