[ 
https://issues.apache.org/jira/browse/NIFI-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307836#comment-15307836
 ] 

ASF GitHub Bot commented on NIFI-1754:
--------------------------------------

Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/478#discussion_r65196703
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
 ---
    @@ -950,6 +955,45 @@ private void rollback(final boolean penalize, final 
boolean rollbackCheckpoint)
             resetState();
         }
     
    +    private String loggableFlowfileInfo() {
    +        final StringBuilder details = new StringBuilder(1024).append("[");
    +        final int initLen = details.length();
    +        int filesListed = 0;
    +        int maxRollbackFlowfilesToLog = 5;
    --- End diff --
    
    This seems like a reasonable default for troubleshooting and likely not 
worth the effort of making it a config option until the utility of this is 
better understood - but should it be a "constant" somewhere?


> Rollback log messages should include the flowfile filename and UUID to assist 
> in flow management.
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1754
>                 URL: https://issues.apache.org/jira/browse/NIFI-1754
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Joe Skora
>            Assignee: Joe Skora
>
> When a processor calls rollback on a flowfile, the filename and UUID of the 
> flowfile should be included in log entry to make it easier for the offending 
> files to be found and fixed or removed from the flow by the dataflow managers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to