[ 
https://issues.apache.org/jira/browse/MINIFI-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300305#comment-15300305
 ] 

ASF GitHub Bot commented on MINIFI-30:
--------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/17#discussion_r64602965
  
    --- Diff: 
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
 ---
    @@ -428,13 +436,26 @@ private static void addProcessGroup(final Element 
parentElement, Map<String, Obj
                 addPosition(element);
                 addTextElement(element, "comment", 
getValueString(flowControllerProperties, COMMENT_KEY));
     
    -            Map<String, Object> processorConfig = (Map<String, Object>) 
topLevelYaml.get(PROCESSOR_CONFIG_KEY);
    -            addProcessor(element, processorConfig);
    +            Collection<Object> processors = (Collection<Object>) 
topLevelYaml.get(PROCESSORS_KEY);
    +            if (processors != null) {
    +                for (Object processorConfig : processors) {
    +                    addProcessor(element, (Map<String, Object>) 
processorConfig);
    +                }
    +            }
     
    -            Map<String, Object> remoteProcessingGroup = (Map<String, 
Object>) topLevelYaml.get(REMOTE_PROCESSING_GROUP_KEY);
    -            addRemoteProcessGroup(element, remoteProcessingGroup);
    +            Map<String, Object> exfilComponent = (Map<String, Object>) 
topLevelYaml.get(EXFIL_COMPONENT_KEY);
    +            if ("Site-To-Site".equals(getValueString(exfilComponent, 
TYPE_KEY))) {
    +                addRemoteProcessGroup(element, exfilComponent);
    +            } else if ("PROCESSOR".equals(getValueString(exfilComponent, 
TYPE_KEY))) {
    --- End diff --
    
    minor:  would be nice to make this a constant as it is used in a few 
different places for the same purpose


> Improve Configuration to Allow Intermediate Processors
> ------------------------------------------------------
>
>                 Key: MINIFI-30
>                 URL: https://issues.apache.org/jira/browse/MINIFI-30
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
>
> Currently the config.yml spec and ConfigTransformer only allow for an input 
> processor and S2S out. Going forward there needs to be a way to have 
> intermediate processors to act on and route data, as well as a way to push 
> data out using a processor (like PutMQTT) instead of S2S



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to