[
https://issues.apache.org/jira/browse/MINIFI-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301972#comment-15301972
]
ASF GitHub Bot commented on MINIFI-30:
--------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/17#discussion_r64732477
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -616,15 +630,21 @@ private static void addConnection(final Element
parentElement, Map<String, Objec
addTextElement(element, "labelIndex", "1");
addTextElement(element, "zIndex", "0");
- addTextElement(element, "sourceId", "Processor");
+ addTextElement(element, "sourceId",
getValueString(connectionProperties, SOURCE_NAME_KEY));
--- End diff --
One additional thought I had was to have another class that perhaps does
the value checking and enforces the config YAML and then passes a value object
(a collection of all the backing maps) to the ConfigTransformer. Long term, we
may not have this particular process and could isolate the actual validation
and checking elsewhere. In lieu of the manual checks, we may be able to make
use of something like [Kwalify](http://www.kuwata-lab.com/kwalify/) (no clue as
to its quality) which might help in cutting down on the onerous and manual if
statements for each individual scalar.
> Improve Configuration to Allow Intermediate Processors
> ------------------------------------------------------
>
> Key: MINIFI-30
> URL: https://issues.apache.org/jira/browse/MINIFI-30
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
>
> Currently the config.yml spec and ConfigTransformer only allow for an input
> processor and S2S out. Going forward there needs to be a way to have
> intermediate processors to act on and route data, as well as a way to push
> data out using a processor (like PutMQTT) instead of S2S
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
