[
https://issues.apache.org/jira/browse/NIFI-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331712#comment-15331712
]
ASF GitHub Bot commented on NIFI-1850:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/511#discussion_r67157791
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-jolt-transform-json-ui/src/main/java/org/apache/nifi/web/util/CustomUIUtils.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.web.util;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.ws.rs.core.CacheControl;
+import javax.ws.rs.core.Response;
+
+import org.apache.nifi.web.ComponentDetails;
+import org.apache.nifi.web.HttpServletConfigurationRequestContext;
+import org.apache.nifi.web.HttpServletRequestContext;
+import org.apache.nifi.web.NiFiWebConfigurationContext;
+import org.apache.nifi.web.NiFiWebConfigurationRequestContext;
+import org.apache.nifi.web.NiFiWebRequestContext;
+import org.apache.nifi.web.Revision;
+import org.apache.nifi.web.UiExtensionType;
+
+
+public class CustomUIUtils {
--- End diff --
Two questions:
1. Given that this is a new class, was your intention to make it public or
its a utility for highly specialized use. If so consider reducing visibility.
2. If it is public I wonder if _ CustomUIUtils_ is the appropriate name
(doesn't tell me anything). Also if it's meant to be public, some javadocs
would be in order.
> JSON-to-JSON Schema Converter Editor
> ------------------------------------
>
> Key: NIFI-1850
> URL: https://issues.apache.org/jira/browse/NIFI-1850
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
> Reporter: Yolanda M. Davis
> Assignee: Yolanda M. Davis
> Priority: Minor
> Fix For: 0.7.0
>
>
> With NIFI-361 implemented, users can embed a JOLT spec into the TransformJSON
> processor. However, building the spec is not intuitive enough without the
> ability to obtain real time feedback on spec syntax and preview output data.
> Would like to have a specification editor and transform preview view added
> to the processor configuration screen to allow users to immediately see the
> impact on the output JSON data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
