[ 
https://issues.apache.org/jira/browse/NIFI-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332325#comment-15332325
 ] 

ASF GitHub Bot commented on NIFI-1850:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/511#discussion_r67223717
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
 ---
    @@ -452,8 +456,40 @@ private ComponentDetails 
getComponentConfiguration(final ProcessorDTO processor)
                         .state(processor.getState())
                         .annotationData(processorConfig.getAnnotationData())
                         .properties(processorConfig.getProperties())
    +                    .descriptors(getComponentDescriptors(processorConfig))
                         
.validateErrors(processor.getValidationErrors()).build();
             }
    +
    +        private Map<String,ComponentDescriptor> 
getComponentDescriptors(final ProcessorConfigDTO processorConfig){
    +
    +            final Map<String, ComponentDescriptor> descriptors = new 
HashMap<>();
    +
    +            for(String key : processorConfig.getDescriptors().keySet()){
    +
    +                PropertyDescriptorDTO descriptor = 
processorConfig.getDescriptors().get(key);
    +                List<PropertyDescriptorDTO.AllowableValueDTO> 
allowableValuesDTO = descriptor.getAllowableValues();
    +                Map<String,String> allowableValues = new HashMap<>();
    +
    +                if(allowableValuesDTO != null) {
    +                    for (PropertyDescriptorDTO.AllowableValueDTO value : 
allowableValuesDTO) {
    +                        allowableValues.put(value.getValue(), 
value.getDisplayName());
    +                    }
    +                }
    +
    +                ComponentDescriptor componentDescriptor = new 
ComponentDescriptor.Builder()
    +                        .name(descriptor.getName())
    +                        .displayName(descriptor.getDisplayName())
    +                        .defaultValue(descriptor.getDefaultValue())
    +                        .allowableValues(allowableValues)
    +                        .build();
    +
    +
    +                descriptors.put(key,componentDescriptor);
    +            }
    +
    +            return descriptors;
    --- End diff --
    
    That's fair. I primarily wanted to raise "what if" awareness ;)


> JSON-to-JSON Schema Converter Editor
> ------------------------------------
>
>                 Key: NIFI-1850
>                 URL: https://issues.apache.org/jira/browse/NIFI-1850
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Core UI
>            Reporter: Yolanda M. Davis
>            Assignee: Yolanda M. Davis
>            Priority: Minor
>             Fix For: 0.7.0
>
>
> With NIFI-361 implemented, users can embed a JOLT spec into the TransformJSON 
> processor. However, building the spec is not intuitive enough without the 
> ability to obtain real time feedback on spec syntax and preview output data. 
> Would like to have a specification editor and transform  preview view added 
> to the processor configuration screen to  allow users to immediately see the 
> impact on the output JSON data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to