[ 
https://issues.apache.org/jira/browse/MINIFI-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706509#comment-15706509
 ] 

ASF GitHub Bot commented on MINIFI-125:
---------------------------------------

Github user brosander commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/59#discussion_r90112258
  
    --- Diff: 
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java 
---
    @@ -357,8 +387,10 @@ private synchronized void saveProperties(final 
Properties nifiProps, final Logge
     
             try {
                 final Set<PosixFilePermission> perms = new HashSet<>();
    -            perms.add(PosixFilePermission.OWNER_READ);
                 perms.add(PosixFilePermission.OWNER_WRITE);
    +            perms.add(PosixFilePermission.OWNER_READ);
    +            perms.add(PosixFilePermission.GROUP_READ);
    +            perms.add(PosixFilePermission.OTHERS_READ);
    --- End diff --
    
    @JPercivall maybe not relevant in MiNiFi context but when I see "others" 
getting permissions I always wonder why it's necessary and if any sensitive 
data can leak.


> Implement applicable NiFi 1.0.0 bootstrap changes to MiNiFi bootstrap
> ---------------------------------------------------------------------
>
>                 Key: MINIFI-125
>                 URL: https://issues.apache.org/jira/browse/MINIFI-125
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
>             Fix For: 0.1.0
>
>
> There were commits improving the NiFi-bootstrap in 1.0.0. Not all of them 
> will be relevant to the MiNiFi bootstrap but some may be. Any applicable 
> changes/improvements should be applied to the MiNiFi Bootstrap.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to