[
https://issues.apache.org/jira/browse/MINIFI-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706749#comment-15706749
]
ASF GitHub Bot commented on MINIFI-125:
---------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/59#discussion_r90129643
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java
---
@@ -367,11 +399,40 @@ private synchronized void saveProperties(final
Properties nifiProps, final Logge
}
try (final FileOutputStream fos = new
FileOutputStream(statusFile)) {
- nifiProps.store(fos, null);
+ minifiProps.store(fos, null);
fos.getFD().sync();
}
- logger.debug("Saved Properties {} to {}", new Object[]{nifiProps,
statusFile});
+ logger.debug("Saved Properties {} to {}", new
Object[]{minifiProps, statusFile});
+ }
+
+ private synchronized void writePidFile(final String pid, final Logger
logger) throws IOException {
+ final File pidFile = getPidFile(logger);
+ if (pidFile.exists() && !pidFile.delete()) {
--- End diff --
I really don't think there is anything we can do about it since each
invocation of minifi.sh is a separate processes. The lock file has the same
potential race condition[1].
[1]
https://github.com/apache/nifi-minifi/blob/master/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java#L751
> Implement applicable NiFi 1.0.0 bootstrap changes to MiNiFi bootstrap
> ---------------------------------------------------------------------
>
> Key: MINIFI-125
> URL: https://issues.apache.org/jira/browse/MINIFI-125
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Fix For: 0.1.0
>
>
> There were commits improving the NiFi-bootstrap in 1.0.0. Not all of them
> will be relevant to the MiNiFi bootstrap but some may be. Any applicable
> changes/improvements should be applied to the MiNiFi Bootstrap.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
