[
https://issues.apache.org/jira/browse/MINIFI-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854214#comment-15854214
]
ASF GitHub Bot commented on MINIFI-189:
---------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/44
looks good and thanks for submitting fix. will get this merged in.
> Check spdlog level before building buffer
> ------------------------------------------
>
> Key: MINIFI-189
> URL: https://issues.apache.org/jira/browse/MINIFI-189
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.1.0, cpp-0.2.0
> Reporter: marco polo
> Assignee: marco polo
> Priority: Trivial
> Fix For: cpp-0.2.0
>
>
> While debugging MINIFI-188 and learning the general process I added a healthy
> amount of logging to some loops that made a noticeable change in performance.
> I made a quick change to the conditionals to check the log level of spd
> logger before constructing or evaluating the var arg list for vsnprintf.
> To remove the reliance on stdio headers I will be changing vsnprintf to
> std::vsnprintf
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
