[
https://issues.apache.org/jira/browse/MINIFI-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854218#comment-15854218
]
ASF subversion and git services commented on MINIFI-189:
--------------------------------------------------------
Commit 9b4bceff32d5b8da03857e810b2d588743d9f220 in nifi-minifi-cpp's branch
refs/heads/master from Marc Parisi
[ https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;h=9b4bcef ]
MINIFI-189: Check log level before buffer operations
Checking the log level before attempting buffer operations has
the impact of avoiding memory and functional calls that are
unnecessary due to the configured level excluding this log
message
This closes #44.
Signed-off-by: Aldrin Piri <[email protected]>
> Check spdlog level before building buffer
> ------------------------------------------
>
> Key: MINIFI-189
> URL: https://issues.apache.org/jira/browse/MINIFI-189
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.1.0, cpp-0.2.0
> Reporter: marco polo
> Assignee: marco polo
> Priority: Trivial
> Fix For: cpp-0.2.0
>
>
> While debugging MINIFI-188 and learning the general process I added a healthy
> amount of logging to some loops that made a noticeable change in performance.
> I made a quick change to the conditionals to check the log level of spd
> logger before constructing or evaluating the var arg list for vsnprintf.
> To remove the reliance on stdio headers I will be changing vsnprintf to
> std::vsnprintf
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
