[ 
https://issues.apache.org/jira/browse/MINIFI-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891182#comment-15891182
 ] 

ASF GitHub Bot commented on MINIFI-229:
---------------------------------------

GitHub user jdye64 opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/61

    MINIFI-229 - Remove third party tests from project

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdye64/nifi-minifi-cpp MINIFI-229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 3843adb9a380caa5e95dad7cdbeea9c64d5d8f10
Author: Jeremy Dyer <[email protected]>
Date:   2017-03-01T22:19:58Z

    MINIFI-229 - Remove third party tests from project

----


> Remove thirdparty library test from project
> -------------------------------------------
>
>                 Key: MINIFI-229
>                 URL: https://issues.apache.org/jira/browse/MINIFI-229
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Jeremy Dyer
>            Assignee: Jeremy Dyer
>
> Thirdparty tests do not seem necessary in the project since it is the 
> responsibility of the source project to handle testing. Having the tests 
> present add more complexity to the project as the build times take long and 
> more dependencies are required. All source code in the "/thirdparty" 
> directory should have its test code removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to