[
https://issues.apache.org/jira/browse/MINIFI-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903208#comment-15903208
]
ASF GitHub Bot commented on MINIFI-229:
---------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/61
hey @jdye64,
I like the same functionality with less code and quicker build times! This
is great.
One small thing is that I believe this completely removes inclusion of
Google Test. If this seems on track with your expectations, could you also
please update the LICENSE to reflect this?
Thanks!
> Remove thirdparty library test from project
> -------------------------------------------
>
> Key: MINIFI-229
> URL: https://issues.apache.org/jira/browse/MINIFI-229
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: Jeremy Dyer
> Assignee: Jeremy Dyer
>
> Thirdparty tests do not seem necessary in the project since it is the
> responsibility of the source project to handle testing. Having the tests
> present add more complexity to the project as the build times take long and
> more dependencies are required. All source code in the "/thirdparty"
> directory should have its test code removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
