[
https://issues.apache.org/jira/browse/MINIFI-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892506#comment-15892506
]
ASF GitHub Bot commented on MINIFI-231:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r103956734
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -108,6 +109,10 @@ class FlowFileRecord
* Create a new flow record
*/
FlowFileRecord(std::map<std::string, std::string> attributes,
ResourceClaim *claim = NULL);
+ /*!
+ * Create a new flow record from repo flow event
+ */
+ FlowFileRecord(FlowFileEventRecord *event);
--- End diff --
why is this not explicit? Please use smart pointers.
> FlowFile Persistent
> --------------------
>
> Key: MINIFI-231
> URL: https://issues.apache.org/jira/browse/MINIFI-231
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: Core Framework, Data Format
> Affects Versions: cpp-1.0.0
> Reporter: bqiu
> Assignee: bqiu
> Fix For: cpp-1.0.0
>
>
> Add FlowFile persistent support
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
