[ 
https://issues.apache.org/jira/browse/MINIFI-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892501#comment-15892501
 ] 

ASF GitHub Bot commented on MINIFI-231:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r103962251
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -197,6 +202,8 @@ class FlowController {
        std::atomic<bool> _initialized;
        //! Provenance Repo
        ProvenanceRepository *_provenanceRepo;
    +   //! FlowFile Repo
    +   FlowFileRepository *_flowfileRepo;
    --- End diff --
    
    Why does this need to be a pointer? Why not use unique/shared pointer 
depending on the need? 


> FlowFile Persistent 
> --------------------
>
>                 Key: MINIFI-231
>                 URL: https://issues.apache.org/jira/browse/MINIFI-231
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: Core Framework, Data Format
>    Affects Versions: cpp-1.0.0
>            Reporter: bqiu
>            Assignee: bqiu
>             Fix For: cpp-1.0.0
>
>
> Add FlowFile persistent support



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to