[
https://issues.apache.org/jira/browse/MINIFI-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956506#comment-15956506
]
ASF GitHub Bot commented on MINIFI-254:
---------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/73
This is pretty fantastic and all the changes look good. Built and ran a
simple flow.
Would you mind if I switched around the order of linter and testing in the
travis file?
From:
`mkdir ./build && cd ./build && cmake .. && make && make linter && ./tests`
to
`mkdir ./build && cd ./build && cmake .. && make && ./tests && make linter`
The primary motivation is that in the review process being able to catch
the test defects is nice and then if there are minor linting issues, it may or
may not require follow up. In the current scenario, a single linter issue will
prevent tests from executing.
Regardless, thanks for cleaning all this up and letting us automate the
process using CI.
> Update codebase to C++ Linter standards
> ---------------------------------------
>
> Key: MINIFI-254
> URL: https://issues.apache.org/jira/browse/MINIFI-254
> Project: Apache NiFi MiNiFi
> Issue Type: Task
> Components: Build
> Reporter: Aldrin Piri
>
> An onerous task not for the faint of heart. Embark at your own peril.
> MINIFI-225 established a linter for use on inspecting the codebase as a
> target of the build. To derive greater value from this and make it a
> mandatory and automated part of our build/review process we need to get the
> current state of the codebase passing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
