[ 
https://issues.apache.org/jira/browse/MINIFI-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956971#comment-15956971
 ] 

ASF GitHub Bot commented on MINIFI-254:
---------------------------------------

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/73
  
    @phrocker code and builds looked good as presented.
    
    unfortunately the rebase after #71 is not a clean one.  I was looking 
through the conflicts, and they are not overly bad, but was wondering if you 
would be able to take a look at them?  They are substantiative enough that I 
think I would want to post a branch for review if I made the changes.
    
    Let me know what works from your side.  Thanks!


> Update codebase to C++ Linter standards
> ---------------------------------------
>
>                 Key: MINIFI-254
>                 URL: https://issues.apache.org/jira/browse/MINIFI-254
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Build
>            Reporter: Aldrin Piri
>
> An onerous task not for the faint of heart. Embark at your own peril.
> MINIFI-225 established a linter for use on inspecting the codebase as a 
> target of the build.  To derive greater value from this and make it a 
> mandatory and automated part of our build/review process we need to get the 
> current state of  the codebase passing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to