[
https://issues.apache.org/jira/browse/MINIFI-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014533#comment-16014533
]
ASF GitHub Bot commented on MINIFI-270:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/99
MINIFI-270: Move Base RPG capabilities back into RemoteProcessGroupPort
This allows us to extend capabilities in RPG into other classes. Since
the same basic functions are the same we can bring the code up from
Processor into RemoteProcessGroupPort.h instead of a separate class.
Updated LICENSE and added concurrentqueue to locking for the object pool.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-270
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 3f9825e48bf340cb9694068cd5873afa28c3ed65
Author: Marc Parisi <phroc...@apache.org>
Date: 2017-05-17T12:18:26Z
MINIFI-270: Move Base RPG capabilities back into RemoteProcessGroupPort
This allows us to extend capabilities in RPG into other classes. Since
the same basic functions are the same we can bring the code up from
Processor into RemoteProcessGroupPort.h instead of a separate class.
Updated LICENSE and added concurrentqueue to locking for the object pool.
----
> some refactor to move site2site protocol out of processor
> ---------------------------------------------------------
>
> Key: MINIFI-270
> URL: https://issues.apache.org/jira/browse/MINIFI-270
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Affects Versions: cpp-0.1.0
> Reporter: bqiu
> Assignee: marco polo
> Priority: Minor
>
> @@ -239,12 +242,21 @@ class Processor : public Connectable, public
> ConfigurableComponent,
> // Trigger the Processor even if the incoming connection is empty
> std::atomic<bool> _triggerWhenEmpty;
>
> - private:
> + //! obtainSite2SiteProtocol for use
> + std::shared_ptr<Site2SiteClientProtocol>
> obtainSite2SiteProtocol(std::string host, uint16_t sport, uuid_t portId);
> phrocker
> phrocker 5 hours ago Contributor
> @benqiu2016 Can you make a ticket to move this out of Processor? It should be
> a separate component. If you make the ticket I'll make this particular change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
