[ 
https://issues.apache.org/jira/browse/MINIFI-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016070#comment-16016070
 ] 

ASF GitHub Bot commented on MINIFI-270:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/99


> some refactor to move site2site protocol out of processor
> ---------------------------------------------------------
>
>                 Key: MINIFI-270
>                 URL: https://issues.apache.org/jira/browse/MINIFI-270
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: cpp-0.1.0
>            Reporter: bqiu
>            Assignee: marco polo
>            Priority: Minor
>             Fix For: cpp-0.3.0
>
>
> @@ -239,12 +242,21 @@ class Processor : public Connectable, public 
> ConfigurableComponent,
>    // Trigger the Processor even if the incoming connection is empty
>    std::atomic<bool> _triggerWhenEmpty;
>  
> - private:
> +  //! obtainSite2SiteProtocol for use
> +  std::shared_ptr<Site2SiteClientProtocol> 
> obtainSite2SiteProtocol(std::string host, uint16_t sport, uuid_t portId);
>   phrocker
> phrocker 5 hours ago Contributor
> @benqiu2016 Can you make a ticket to move this out of Processor? It should be 
> a separate component. If you make the ticket I'll make this particular change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to