[ 
https://issues.apache.org/jira/browse/MINIFI-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060017#comment-16060017
 ] 

ASF GitHub Bot commented on MINIFI-324:
---------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/115

    MINIFI-324 - More flexible uid generation

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] - N/A - If adding new dependencies to the code, are these 
dependencies licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] - N/A - If applicable, have you updated the LICENSE file?
    - [X] - N/A - If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi-cpp MINIFI-324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 2ce366c5547aa6608653ce71d98e335ff3a0a9ff
Author: Bryan Rosander <[email protected]>
Date:   2017-06-21T18:29:03Z

    MINIFI-324 - More flexible uid generation

----


> Explore alternative ways to supply identifiers
> ----------------------------------------------
>
>                 Key: MINIFI-324
>                 URL: https://issues.apache.org/jira/browse/MINIFI-324
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: marco polo
>            Assignee: Bryan Rosander
>            Priority: Minor
>
> As [[email protected]] mentioned, we could either increment a value in 
> place of generating unique identifiers for any non NiFi related comms ( i.e. 
> internal objects, claims, etc )
> Generating unique identifiers is costly and this may not be a cost all 
> consumers wish to incur. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to