[
https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159274#comment-16159274
]
ASF GitHub Bot commented on MINIFI-339:
---------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137824349
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -43,14 +44,15 @@ class RemoteProcessorGroupPort : public core::Processor
{
/*!
* Create a new processor
*/
- RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, std::string name, std::string url, std::shared_ptr<Configure>
configure, uuid_t uuid = nullptr)
+ RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, std::string name, std::string url, const
std::shared_ptr<Configure> &configure, uuid_t uuid = nullptr)
: core::Processor(name, uuid),
configure_(configure),
direction_(SEND),
transmitting_(false),
+ timeout_(0),
logger_(logging::LoggerFactory<RemoteProcessorGroupPort>::getLogger()),
url_(url),
- securityConfig_(configure) {
+
ssl_service(std::make_shared<controllers::SSLContextService>("RemoteProcessorGroupPortSSLContextService",
configure)) {
--- End diff --
Should we be using a ControllerServiceProvider here rather than
constructing the SSLContextService directly?
> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
> Key: MINIFI-339
> URL: https://issues.apache.org/jira/browse/MINIFI-339
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and
> likely have public and private elements. As development progresses we may
> want more capabilities.
> What I want to create as a straw man will be basic control and metrics
> gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
> ** Throughput of of flow components
> ** Execution time ( run time minus sleep time )
> ** Memory consumption
> -- Drain repositories
> -- Switch repository types.
> Better employ update listener within this controlling API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
