[
https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159278#comment-16159278
]
ASF GitHub Bot commented on MINIFI-339:
---------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137835890
--- Diff: libminifi/include/ResourceClaim.h ---
@@ -83,13 +83,19 @@ class ResourceClaim : public
std::enable_shared_from_this<ResourceClaim> {
}
void deleteClaim() {
- if (!deleted_)
- {
+ if (!deleted_) {
deleted_ = true;
}
}
+ bool exists(){
+ if (claim_manager_ == nullptr){
+ return false;
--- End diff --
This could lead to subtle bugs where a programming error (not
setting/initializing claim_manager_) would appear as a runtime state or error
condition (file lost/doesn't exist).
> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
> Key: MINIFI-339
> URL: https://issues.apache.org/jira/browse/MINIFI-339
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and
> likely have public and private elements. As development progresses we may
> want more capabilities.
> What I want to create as a straw man will be basic control and metrics
> gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
> ** Throughput of of flow components
> ** Execution time ( run time minus sleep time )
> ** Memory consumption
> -- Drain repositories
> -- Switch repository types.
> Better employ update listener within this controlling API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
