[ 
https://issues.apache.org/jira/browse/MINIFI-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295230#comment-16295230
 ] 

Aldrin Piri commented on MINIFI-420:
------------------------------------

Looks like the component descriptor for the source release is inherited from 
the apache parent and attempts to append a descriptor via the 
maven-assembly-plugin aren't working to exclude these files specifically.  Will 
opt to move things to target upon download.

> Cached Windows service executables can leak into generated source packages
> --------------------------------------------------------------------------
>
>                 Key: MINIFI-420
>                 URL: https://issues.apache.org/jira/browse/MINIFI-420
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.3.0
>            Reporter: Koji Kawamura
>            Assignee: Aldrin Piri
>             Fix For: 0.3.0
>
>
> During the RC2 of the MiNiFi 0.3.0 release it was identified that the 
> candidate source package had executables in it related to the Windows service 
> enablement.  
> The files are provided such that we cache them so that there is no need to 
> repeatedly download the package assembly.
> Given that .exe is also in .gitignore, a git clean -fd would not remove 
> these. (-fxd would)
> There are two options that come to mind to help remedy this issue and make 
> things a bit less error prone.  One is to move the acquired executables and 
> package to target.  However, given that most folks are likely to do a mvn 
> clean <goals> this would likely defeat the purpose of caching entirely.  The 
> other option is to provide configuration to the maven source plugin to 
> exclude these items.  This would allow us to more effectively cache these 
> items but also provide a clean source release that would function as 
> anticipated on build.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to