[
https://issues.apache.org/jira/browse/MINIFI-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295357#comment-16295357
]
ASF GitHub Bot commented on MINIFI-420:
---------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/107
MINIFI-420 Migrate Windows service executable handling to minifi-assembly
MINIFI-420 Migrate Windows service executable handling to minifi-assembly
to avoid executables in source packages.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi-minifi folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under minifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under minifi-assembly?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-420
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 0603a93b9142da75f930e517d41db0fad1b3a513
Author: Aldrin Piri <[email protected]>
Date: 2017-12-18T17:49:38Z
MINIFI-420 Migrate Windows service executable handling to minifi-assembly
to avoid executables in source packages.
----
> Cached Windows service executables can leak into generated source packages
> --------------------------------------------------------------------------
>
> Key: MINIFI-420
> URL: https://issues.apache.org/jira/browse/MINIFI-420
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.3.0
> Reporter: Koji Kawamura
> Assignee: Aldrin Piri
> Fix For: 0.3.0
>
>
> During the RC2 of the MiNiFi 0.3.0 release it was identified that the
> candidate source package had executables in it related to the Windows service
> enablement.
> The files are provided such that we cache them so that there is no need to
> repeatedly download the package assembly.
> Given that .exe is also in .gitignore, a git clean -fd would not remove
> these. (-fxd would)
> There are two options that come to mind to help remedy this issue and make
> things a bit less error prone. One is to move the acquired executables and
> package to target. However, given that most folks are likely to do a mvn
> clean <goals> this would likely defeat the purpose of caching entirely. The
> other option is to provide configuration to the maven source plugin to
> exclude these items. This would allow us to more effectively cache these
> items but also provide a clean source release that would function as
> anticipated on build.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
