[
https://issues.apache.org/jira/browse/MINIFI-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405192#comment-16405192
]
ASF GitHub Bot commented on MINIFI-444:
---------------------------------------
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/118#discussion_r175529769
--- Diff:
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/Device.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.minifi.c2.model;
+
+public class Device extends DeviceInfo {
+
+ private String name;
+ private String firstSeen;
--- End diff --
Yes, they should be timestamps. I meant to ask this question, so I'll just
ask this here: what should the preferred JSON format of timestamps be for the
C2 server REST API? We can go with Epoch time or another standard
representation such as [RFC 3339](https://tools.ietf.org/html/rfc3339), which
is a stricter version of ISO 8601, e.g., 2018-03-19T17:51:00+00:00. If Epoch
time, this field would change to a long of course, but should the units be
seconds or milliseconds since epoch?
> MiNiFi C2 Server model for C2 Protocol and Flow Designer
> --------------------------------------------------------
>
> Key: MINIFI-444
> URL: https://issues.apache.org/jira/browse/MINIFI-444
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Reporter: Kevin Doran
> Assignee: Kevin Doran
> Priority: Major
>
> Draft a data model and rest api into the C2 server that would support the
> feature proposals of a MiNiFi Agent C2 protocol [1] and a MiNiFi Flow
> Designer [2]
> [1] [https://cwiki.apache.org/confluence/display/MINIFI/C2+Design+Proposal]
> [2]
> [http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-MiNiFi-Flow-Designer-td18031.html]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
