[ 
https://issues.apache.org/jira/browse/MINIFI-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405449#comment-16405449
 ] 

ASF GitHub Bot commented on MINIFI-444:
---------------------------------------

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/118#discussion_r175586309
  
    --- Diff: 
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/PropertyDescriptor.java
 ---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.c2.model.extension;
    +
    +import io.swagger.annotations.ApiModel;
    +import io.swagger.annotations.ApiModelProperty;
    +
    +import java.util.List;
    +
    +@ApiModel
    +public class PropertyDescriptor {
    +
    +    private String name;
    +    private String displayName;
    +    private String description;
    +    private List<PropertyAllowableValue> allowableValues;
    +    private String defaultValue;
    +    private Boolean required;
    +    private Boolean sensitive;
    +    private Boolean supportsEl;
    +    private DefinedType identifiesControllerServiceApi;
    --- End diff --
    
    No, but I can see how the field name is misleading. The intention of this 
field is to indicate if the property value identifies a Controller Service API, 
and if so, which DefinedType that API is. This is used in NiFi to present a 
drop down menu of any ExtensionComponents that implement that API.
    
    See the comment about which is related to this field.
    
    If this API definition+implementation metadata complexity is not needed in 
this initial version of this workflow, or if it is too difficult to provide, we 
could leave it out and reintroduce it in a future version of C2 server.


> MiNiFi C2 Server model for C2 Protocol and Flow Designer
> --------------------------------------------------------
>
>                 Key: MINIFI-444
>                 URL: https://issues.apache.org/jira/browse/MINIFI-444
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>            Reporter: Kevin Doran
>            Assignee: Kevin Doran
>            Priority: Major
>
> Draft a data model and rest api into the C2 server that would support the 
> feature proposals of a MiNiFi Agent C2 protocol [1] and a MiNiFi Flow 
> Designer [2] 
> [1] [https://cwiki.apache.org/confluence/display/MINIFI/C2+Design+Proposal]
> [2] 
> [http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-MiNiFi-Flow-Designer-td18031.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to