NIFI-289: - Added logging when error conditions occur in UpdateAttribute REST endpoints.
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/93b78a7d Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/93b78a7d Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/93b78a7d Branch: refs/heads/NIFI-250 Commit: 93b78a7dd5d4e4fa43fc84c5992010389638d595 Parents: 600a47b Author: Matt Gilman <[email protected]> Authored: Mon Feb 2 14:02:24 2015 -0500 Committer: Matt Gilman <[email protected]> Committed: Mon Feb 2 14:02:24 2015 -0500 ---------------------------------------------------------------------- .../nifi/update/attributes/api/RuleResource.java | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/93b78a7d/nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java ---------------------------------------------------------------------- diff --git a/nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java b/nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java index 05ed0a1..dc2d27c 100644 --- a/nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java +++ b/nifi/nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java @@ -70,6 +70,8 @@ import com.sun.jersey.api.NotFoundException; import org.apache.nifi.update.attributes.FlowFilePolicy; import org.apache.nifi.update.attributes.entity.EvaluationContextEntity; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * @@ -77,6 +79,8 @@ import org.apache.nifi.update.attributes.entity.EvaluationContextEntity; @Path("/criteria") public class RuleResource { + private static final Logger logger = LoggerFactory.getLogger(RuleResource.class); + @Context private ServletContext servletContext; @@ -612,7 +616,9 @@ public class RuleResource { } catch (final InvalidRevisionException ire) { throw new WebApplicationException(invalidRevision(ire.getMessage())); } catch (final Exception e) { - throw new WebApplicationException(error(e.getMessage())); + final String message = String.format("Unable to get UpdateAttribute[id=%s] criteria: %s", contextConfig.getProcessorId(), e); + logger.error(message, e); + throw new WebApplicationException(error(message)); } Criteria criteria = null; @@ -620,7 +626,9 @@ public class RuleResource { try { criteria = CriteriaSerDe.deserialize(processorInfo.getAnnotationData()); } catch (final IllegalArgumentException iae) { - throw new WebApplicationException(error("Unable to load existing rules. Deserialization error: " + iae.getMessage())); + final String message = String.format("Unable to deserialize existing rules for UpdateAttribute[id=%s]. Deserialization error: %s", contextConfig.getProcessorId(), iae); + logger.error(message, iae); + throw new WebApplicationException(error(message)); } } // ensure the criteria isn't null @@ -644,7 +652,9 @@ public class RuleResource { } catch (final InvalidRevisionException ire) { throw new WebApplicationException(invalidRevision(ire.getMessage())); } catch (final Exception e) { - throw new WebApplicationException(error(e.getMessage())); + final String message = String.format("Unable to save UpdateAttribute[id=%s] criteria: %s", contextConfig.getProcessorId(), e); + logger.error(message, e); + throw new WebApplicationException(error(message)); } }
