NIFI-268: Change Assert.fail to logger.warn if using deprecated annotation for processors. This will be cahnged to Assert.fail in 0.1.0 but should not happen for version 0.0.2
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/3b399d75 Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/3b399d75 Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/3b399d75 Branch: refs/heads/NIFI-250 Commit: 3b399d75044ba2bc52d6876e7fe295f85b9a1264 Parents: 10714ef Author: Mark Payne <[email protected]> Authored: Tue Feb 3 12:09:42 2015 -0500 Committer: Mark Payne <[email protected]> Committed: Tue Feb 3 12:09:42 2015 -0500 ---------------------------------------------------------------------- .../org/apache/nifi/util/StandardProcessorTestRunner.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/3b399d75/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java ---------------------------------------------------------------------- diff --git a/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java b/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java index 63d1c9f..f3fd3e8 100644 --- a/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java +++ b/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java @@ -66,6 +66,8 @@ import org.apache.nifi.processor.Relationship; import org.apache.nifi.provenance.ProvenanceReporter; import org.apache.nifi.reporting.InitializationException; import org.junit.Assert; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class StandardProcessorTestRunner implements TestRunner { @@ -80,6 +82,7 @@ public class StandardProcessorTestRunner implements TestRunner { private int numThreads = 1; private final AtomicInteger invocations = new AtomicInteger(0); + private static final Logger logger = LoggerFactory.getLogger(StandardProcessorTestRunner.class); private static final Set<Class<? extends Annotation>> deprecatedTypeAnnotations = new HashSet<>(); private static final Set<Class<? extends Annotation>> deprecatedMethodAnnotations = new HashSet<>(); @@ -134,14 +137,14 @@ public class StandardProcessorTestRunner implements TestRunner { private static void detectDeprecatedAnnotations(final Processor processor) { for ( final Class<? extends Annotation> annotationClass : deprecatedTypeAnnotations ) { if ( processor.getClass().isAnnotationPresent(annotationClass) ) { - Assert.fail("Processor is using deprecated Annotation " + annotationClass.getCanonicalName()); + logger.warn("Processor is using deprecated Annotation " + annotationClass.getCanonicalName()); } } for ( final Class<? extends Annotation> annotationClass : deprecatedMethodAnnotations ) { for ( final Method method : processor.getClass().getMethods() ) { if ( method.isAnnotationPresent(annotationClass) ) { - Assert.fail("Processor is using deprecated Annotation " + annotationClass.getCanonicalName() + " for method " + method); + logger.warn("Processor is using deprecated Annotation " + annotationClass.getCanonicalName() + " for method " + method); } } }
