[
https://issues.apache.org/jira/browse/NIFI-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521953#comment-14521953
]
Mark Payne commented on NIFI-144:
---------------------------------
Code in the patch seems reasonable. I applied it and verified that everything
still works for me, as it always has. No issues.
+1. Will push changes to develop later today.
> Test Failure:
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> ------------------------------------------------------------------------------------
>
> Key: NIFI-144
> URL: https://issues.apache.org/jira/browse/NIFI-144
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.0.1
> Environment: OS X 10.9
> Maven 3.2.3 (via homebrew)
> JDK 1.7.0_72
> Reporter: Aldrin Piri
> Assignee: Sean Busbey
> Fix For: 0.1.0
>
> Attachments: NIFI-144.1.patch.txt
>
>
> Running org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6
> IP(s) to firewall. Only requests originating from the configured IPs will be
> accepted.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading
> cluster firewall configuration.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs
> added to firewall. Firewall will accept all requests.
> [main] INFO
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster
> firewall configuration loaded.
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.35 sec <<<
> FAILURE! - in
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> testIsPermissibleWithMalformedData(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
> Time elapsed: 0.437 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at org.junit.Assert.assertFalse(Assert.java:74)
> at
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData(FileBasedClusterNodeFirewallTest.java:79)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
