[ 
https://issues.apache.org/jira/browse/NIFI-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536119#comment-14536119
 ] 

Joseph Witt commented on NIFI-144:
----------------------------------

>From the NiFi 0.1.0 RC 12 vote by Brandon DeVries:

-1.  I'm seeing something that appears to be related to NIFI-144[1].  These
are the test failure I'm getting:


-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.nifi.cluster.event.impl.EventManagerImplTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
in org.apache.nifi.cluster.event.impl.EventManagerImplTest
Running
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
Tests run: 8, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.389 sec
<<< FAILURE! - in
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
testIsPermissibleWithMalformedData(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
Time elapsed: 0.032 sec  <<< FAILURE!
java.lang.AssertionError: firewall allowed host 'abc' rather than rejecting
as malformed. If `host abc` works locally, this test should have been
skipped.
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData(FileBasedClusterNodeFirewallTest.java:115)

ensureBadDataWasIgnored(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
Time elapsed: 0.003 sec  <<< FAILURE!
java.lang.AssertionError: firewall treated our malformed data as a host. If
`host "bad data should be skipped"` works locally, this test should have
been skipped.
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.ensureBadDataWasIgnored(FileBasedClusterNodeFirewallTest.java:82)

Running org.apache.nifi.cluster.flow.impl.DataFlowManagementServiceImplTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.578 sec -
in org.apache.nifi.cluster.flow.impl.DataFlowManagementServiceImplTest
Running org.apache.nifi.cluster.manager.impl.HttpRequestReplicatorImplTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.584 sec
- in org.apache.nifi.cluster.manager.impl.HttpRequestReplicatorImplTest
Running org.apache.nifi.cluster.manager.impl.HttpResponseMapperImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec -
in org.apache.nifi.cluster.manager.impl.HttpResponseMapperImplTest
Running org.apache.nifi.cluster.manager.impl.TestWebClusterManager
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec -
in org.apache.nifi.cluster.manager.impl.TestWebClusterManager

Results :

Failed tests:
  FileBasedClusterNodeFirewallTest.ensureBadDataWasIgnored:82 firewall
treated our malformed data as a host. If `host "bad data should be
skipped"` works locally, this test should have been skipped.
  FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData:115
firewall allowed host 'abc' rather than rejecting as malformed. If `host
abc` works locally, this test should have been skipped.



Tests run: 41, Failures: 2, Errors: 0, Skipped: 0


When i run the "host" commands suggested in the failure messages, I get:

BRANDONs-MacBook-Pro:nifi-0.1.0-incubating brandon$ host abc
abc has address 92.242.140.21
Host abc not found: 3(NXDOMAIN)
BRANDONs-MacBook-Pro:nifi-0.1.0-incubating brandon$ host "bad data should
be skipped"
bad\032data\032should\032be\032skipped has address 92.242.140.21
Host bad\032data\032should\032be\032skipped not found: 3(NXDOMAIN)


[1] https://issues.apache.org/jira/browse/NIFI-144

> Test Failure: 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> ------------------------------------------------------------------------------------
>
>                 Key: NIFI-144
>                 URL: https://issues.apache.org/jira/browse/NIFI-144
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.0.1
>         Environment: OS X 10.9
> Maven 3.2.3 (via homebrew)
> JDK 1.7.0_72
>            Reporter: Aldrin Piri
>            Assignee: Sean Busbey
>             Fix For: 0.1.0
>
>         Attachments: NIFI-144.1.patch.txt
>
>
> Running org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Added 6 
> IP(s) to firewall.  Only requests originating from the configured IPs will be 
> accepted.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Loading 
> cluster firewall configuration.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - No IPs 
> added to firewall.  Firewall will accept all requests.
> [main] INFO 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewall - Cluster 
> firewall configuration loaded.
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.35 sec <<< 
> FAILURE! - in 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> testIsPermissibleWithMalformedData(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
>   Time elapsed: 0.437 sec  <<< FAILURE!
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertFalse(Assert.java:64)
>       at org.junit.Assert.assertFalse(Assert.java:74)
>       at 
> org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData(FileBasedClusterNodeFirewallTest.java:79)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to