[
https://issues.apache.org/jira/browse/NIFI-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599367#comment-14599367
]
Matt Gilman commented on NIFI-632:
----------------------------------
[~danbress] Sorry it's taken so long to get back to this. I believe that
[~markap14] as already reviewed the NIFI-674 aspects of this patch. I just
verified the changes address the issues I was seeing that trigger this creation
of this ticket initially.
+1
A couple notes... I realize this was quite involved and there are some
tradeoffs when dealing with the existing codebase which may have made the
possible solutions more difficult.
+1 for finding a couple other issues/bugs while working this ticket
+0 for a partial copy of ReflectionUtils.
+0 for triggering OnRemoved and OnShutdown after initialization and before
being done with instance
+0 for triggering OnRemoved and OnShutdown and not their deprecated counterparts
> Documentation Generation: Nar ClassLoader
> -----------------------------------------
>
> Key: NIFI-632
> URL: https://issues.apache.org/jira/browse/NIFI-632
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.1.0
> Reporter: Matt Gilman
> Assignee: Dan Bress
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 0001-Squashed-commit-of-the-following.patch
>
>
> When auto generating component documentation the NarThreadContextClassLoader
> needs to be set in case the component attempts to load anything off of its
> classpath. Without this, the documentation generation fails.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)